Test kubernetes in CI #3482
Draft
Test kubernetes in CI #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes worker pod configuration
…as-expected as root
many of these newly marked "no shared fs" tests do not need to be shared fs, but instead could be staging-based? it would be good to test the tests that aren't marked as staging required with no staging providers configured, even in normal CI, to validate that test mark is applied properly. should also rewrite the mark name as shared_fs_required to match the X_required format?
|
this is failing repeatedly on this test: (at 5c55fe6) (most recently with a |
…ular test, or something else
…=[] in local htex test...)
benclifford
changed the title
…read_namespaced_pod(), which is functionally the same but requires fewer permissions.
…nto benc-k8s-kind-ci
…able to deal with staging those files properly (or it might be good to flush out more test problems)
… benc-k8s-kind-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a codification of what I had to do to get
pytestpassing for myself while trying to review other kubernetes PRs.The bulk of the modified files are additional test markings to label which tests require a shared filesystem (between all workers and the submit side) to store working files; and which tests require file staging (as the default file staging configuration is not valid for kubernetes, due to lack of shared file system).
There is also a bugfix for default pod names being generated as invalid format (which can fixed by users by specifying an explicit prefix)
This PR can probably be merged into master in a few stages.